+ Reply to Thread
Results 1 to 8 of 8

Thread: noindex for expired listings

  1. #1
    Master
    Join Date
    Apr 2017
    Location
    Tehran/Iran
    Posts
    461

    noindex for expired listings

    Hello Rudi,

    Please refer to rlCommon.class.php -> function metaRobots() and let me know the reason for below code:

    Code:
    Only registered members can view the code.
    It changes meta robots to noindex when listing is expired. But it never happens, because $GLOBALS['listing_data']['Listing_expired'] never be true for expired listings by Cron. You can check with any listings with status='expired' by Cron

    I already explained the problem in details at this post:
    https://forum.flynax.com/showthread....ll=1#post24226

    Please clarify me about it.
    Last edited by Bahram Soltanirad; May 19, 2021 at 04:52 AM.

  2. #2
    Flynax developer Rudi's Avatar
    Join Date
    Dec 2014
    Location
    Planet Earth
    Posts
    2,180
    Hello Bahram,

    Actually, it's ok,

    this variable is calculated in listing_details.inc.php in sql request at the top of the file

  3. #3
    Master
    Join Date
    Apr 2017
    Location
    Tehran/Iran
    Posts
    461
    Quote Originally Posted by Rudi View Post
    Hello Bahram,

    Actually, it's ok,

    this variable is calculated in listing_details.inc.php in sql request at the top of the file
    Yes, it has been defined at below line:

    Code:
    Only registered members can view the code.
    But the point is: When a listing is expired by cron, the `T1`.`Pay_date` set to '' (0000-00-00 00:00:00)

    Please see cron/index.php line 132: $action_update['Pay_date'] = '';

    And as you see, it causes False or 0 for Listing_expired at above code

  4. #4
    ok I'm not sure if this relevant. But in version 4.8.1 I'm using in admincp, all expired listing has Payment Date shows: 00-1-11-30 00:00:00. Please check my screenshot.
    Screen Shot 2021-05-19 at 2.12.08 PM.png

    isnt it supposed to show the lastest payment date?

  5. #5
    Flynax developer Rudi's Avatar
    Join Date
    Dec 2014
    Location
    Planet Earth
    Posts
    2,180
    Ok, I see,

    I'll create a task regarding this issue and we'll discuss what could be the best solution for this because, ideally, all listings should be indexed including expired (for SEO purpose)


    Quote Originally Posted by Wei Hong View Post
    ok I'm not sure if this relevant. But in version 4.8.1 I'm using in admincp, all expired listing has Payment Date shows: 00-1-11-30 00:00:00. Please check my screenshot.
    Attachment 4197

    isnt it supposed to show the lastest payment date?
    It seems that the default date value is not 00-0-00-00 00:00:00 in your database

    you need to check your database settings

    or set '00-0-00-00 00:00:00' instead of ''

  6. #6
    Quote Originally Posted by Rudi View Post
    Ok, I see,

    I'll create a task regarding this issue and we'll discuss what could be the best solution for this because, ideally, all listings should be indexed including expired (for SEO purpose)




    It seems that the default date value is not 00-0-00-00 00:00:00 in your database

    you need to check your database settings

    or set '00-0-00-00 00:00:00' instead of ''
    Hi Rudi,
    This is new to me. Should I look in cpanel or phpmyadmin? So after I change to default 0-0-0 then the expired listing will have the latest payment date show right?

  7. #7
    Flynax developer Rudi's Avatar
    Join Date
    Dec 2014
    Location
    Planet Earth
    Posts
    2,180
    Actually, I mean when the cron file sets '' for expired listings

  8. #8
    Quote Originally Posted by Rudi View Post
    Actually, I mean when the cron file sets '' for expired listings
    Hi Rudi,

    I check cron setting in cpanel and here is the setting
    Screen Shot 2021-05-20 at 9.21.47 AM.png

    Also just look at the cron/index.php file for expired listing for default date. It's not there so I think may be setting in cpanel?
    Any way I have no problem with cron, it just in admincp all expired listing has the same payment date 00-1-11-30 00:00:00. I want it to show the latest or the previous payment date.

+ Reply to Thread