+ Reply to Thread
Results 1 to 6 of 6

Thread: Cant see Thumbs sometimes

  1. #1

    Cant see Thumbs sometimes

    Hello dear flynax team,

    Have this problem sometimes:



    Images links are good, (i can see it if i copy & paste link from inspector), but on website its looks like on image

  2. #2
    Flynax developer Rudi's Avatar
    Join Date
    Dec 2014
    Location
    Planet Earth
    Posts
    2,187
    Hello,

    It's due to symbol " which is in listing title, namely, in field "Title"

    and it breaks img tag because listing title is used for img attributes alt and title

    I've added some solution to templates > auto_nova > tpl > controllers > listing_details.tpl

    to escape double quotes in text for img title

  3. #3
    Senior Member
    Join Date
    Sep 2019
    Location
    Australia mate.
    Posts
    150
    Hi Rudi,

    When you add fixes such as this, could you please include details of the fix so that others can also make adjustments to their sites? I realise it will take you a little more time but probably save everyone time in the long run.

  4. #4
    Flynax developer Rudi's Avatar
    Join Date
    Dec 2014
    Location
    Planet Earth
    Posts
    2,187
    ok, but we suggest to avoid using double quotes " in text, especially when importing listings via XML and XLS plugins

    because it can cause unexpected errors throughout the script

    change the code for thumbnails in listing_details.tpl

    from:
    Code:
    Only registered members can view the code.
    to:
    Code:
    Only registered members can view the code.

  5. #5
    Senior Member
    Join Date
    Sep 2019
    Location
    Australia mate.
    Posts
    150
    Thanks Rudi, appreciate it.

    Are site users able to create this situation where a double quote in any of their self entered field data will create this problem or does the script already strip these characters out in 4.8 ?

  6. #6
    Flynax developer Rudi's Avatar
    Join Date
    Dec 2014
    Location
    Planet Earth
    Posts
    2,187
    Yes, the problem can be reproduced currently once you add quotes to the title,

    I've created a task about this bug

+ Reply to Thread