CRITICAL FLAW: Renew upgrade feature doesn't work as it should

[Chris Brown]

I have been keeping tabs on this thread as i want when a listing is renewed the date posted changes so like said its bumped to the top.

Do the changes earlier in this thread work?

I then see there is discussion of stacking up listing time.

I thought i would test this, so i created a test listing and renewed it straight away. Then i renewed it again and again all within 2 minutes. now the listing is now active till April 11th.

Is this the problem you guys mean?

I can see this being an issue for free listings as it can be taken advantage of, but if they are paid listings shouldnt it work like that. As if they do it 2 times they will have paid 2 times.

I think a better solution is for the renew button to be hidden until its time/the email is sent out to renew. Configure it to show up when the email is sent to the user
Which is in admin/configurations/cron-job/Send an expiration notice in advance.


Any thoughts?

[Mike]

As i told here is alternative solution, its Renew Listing Date button this function is stand alone from the upgrade process and can be used if you dont charge your users for renewing listings


1. templates/yourtemplate/tpl/blocks/my_listing.tpl

Only registered members can view the code.

2. includes/controllers/my_listings.inc.php

Only registered members can view the code. 

3. includes/classes/rlListings.class.php

add this function

Only registered members can view the code. 

4. login to admin panel, go to languages page and add frontend phrase with key notice_listing_renewed and text Listing renewed



Its possible to improve function to limit it to one renew per hour or something like this, if you interested lets clarify how would be better, i will add it

[Wei Hong]

As i told here is alternative solution, its Renew Listing Date button this function is stand alone from the upgrade process and can be used if you dont charge your users for renewing listings


1. templates/yourtemplate/tpl/blocks/my_listing.tpl

Only registered members can view the code.

2. includes/controllers/my_listings.inc.php

Only registered members can view the code. 

3. includes/classes/rlListings.class.php

add this function

Only registered members can view the code. 

4. login to admin panel, go to languages page and add frontend phrase with key notice_listing_renewed and text Listing renewed



Its possible to improve function to limit it to one renew per hour or something like this, if you interested lets clarify how would be better, i will add it

Wow, this is excellent. And the idea of limiting it to one renew per hour is also a great idea. Please do guide us. Thank you very much, Mike. Excellent job

[Petrache Nicolae]

As i told here is alternative solution, its Renew Listing Date button this function is stand alone from the upgrade process and can be used if you dont charge your users for renewing listings
Its possible to improve function to limit it to one renew per hour or something like this, if you interested lets clarify how would be better, i will add it

hello Mike. can you provide some details about this? exactly how should be used.

my case is 1 type of plan wich allows 1 free ad with unlimited use.

should i make this plan valid for 31 days and after that the ad expires and the user can click on renew button and the ad is renewed with 31 days and moved in the top of the ads list?
or
should i make the plan valid for 9999 days and after 100 days (for instance) the user clicks on renew button and the ad is is renewed with 31 days and moved in the top of the ads list?

what about the "Upgrade listing plan" button? if we have just 1 single plan, why this is not hidden by the script? users will get confused about this. a fix for this bug please?

the first part of the thread dealed with this "Upgrade listing plan" button wich worked ok, the ad was renewed with another 31 days and moved as first but had 2 issues - it can be used at every minute and by each every minute use the date would stack up.

[Morgan Bohman]

@Mike,
Hm this won't work for me as the text button is not visible. I have only a button for Uppgrade Listing?

Ok have the button now but nothing happens when clicking and when refreshing the listing still expired and the date is set to 1-11-30. Seems like the $sql ="UPDATE `".RL_DBPREFIX."listings` SET `Date` = 'NOW()' WHERE `ID` =".$id; set the date to 1-11-30 anyone in for help?

OK sorted it out ---> 'NOW()' have to be NOW() in the line above. But still the response line is something wrong with.
//Morgan

[Morgan Bohman]

Apart from the response message, this works great, but Mike, can you check if we could have the renew function inside admin panel also?

//Morgan

[Mike]

Hi Morgan,

Yes thanks, my mistake with 'NOW()', i have corrected it in instruction.
Ok here is for admin panel.


1.admin/tpl/listings.tpl

Only registered members can view the code.

2. includes/classes/admin/rlListings.class.php be carefull, dont mix with rlListings in classes directory

find function ajaxMassActions and modify as shown below

Only registered members can view the code. 

[Morgan Bohman]

Thanks Mike, any clue why the response is not showing up? Checked the lang_key but only in swedish maybe needed in english too?
//Morgan

[Mike]

Thanks Mike, any clue why the response is not showing up? Checked the lang_key but only in swedish maybe needed in english too?
//Morgan

yes its admin/tpl/controllers/listings.tpl

i forgot to say that you have to add 'ext_renew' lang phrase with module 'ext' and text Renew

[Morgan Bohman]

Ok hope you meant admin/tpl/controllers/listings.tpl? The other one is hard to find exact right place to put in the code, can you show me specific? Anyway, I can not get this to work.

//Morgan