CRITICAL PLAN BUG: incorrect calculation and featured status removed if renew regular

So here I am again with the same bug. This time I'm pushing it further for a fix since it's been 2 years already.
Bugs on all versions from 4.6.2 to 4.8.1

Quote:

---

Who will get effect by this bugs:
1. If you offer listing plan with different duration. For example: a plan with 3 days active and another plan with 5 days active.
2. If you offer a featured plan.

---

Quote:

---

Here is the video of me demonstrate the bugs 1 and 2 said above on Flynax Demo 4.8.1. Please watch it
https://youtu.be/qqbjaythQuE

---

A. BREAK DOWN PROBLEM 1: RENEWING LISTING WITH DIFFERENT DURATION PLAN

Here is the break down of problem 1 from Video above. User renew their listing with different duration plans.

Quote:

---

Step 1. Apply plan: 3-day
15 Jan

Step 2. Apply plan: 5-day
22 Jan - Incorrect. Should be 20 Jan ( 15 + 5 = 20 )

Step 3. Apply plan: 5-day again
27 Jan - Correct.

Step 4. Apply plan: 5-day again
1 Feb - Correct.

Step 5. Apply plan: 5-day again
6 Feb - Correct.

Step 6. Apply plan: 3-day
7 Feb - Incorrect. Should be 9 Feb. ( 6 + 3 = 9 )

Step 7. Apply plan: 3-day again
10 Feb - Correct.

Step 8. Apply plan: 5-day
17 Feb - Incorrect. Should be 15 Feb ( 10 + 5 = 15 )

Step 9. Apply plan: 3-day
18 Feb - Incorrect. Should be 20 Feb ( 17 + 3 = 20 )

---

Conclusion: As you can see, if you renew listing with the same plan, same duration, whether it's a 3-day plan or 5-day plan. Everything works OK, the math add correctly.

PROBLEM when you renew listing from 3-day to 5-day or vise versa.
From what I observe: if your current plan is less than the plan you renew to: 3-day -> 5-day: Flynax add to your active day both 3 and 5 day, rather than just 5. See step 2 and 8.
If your current plan is more than the plan you renew to: 5-day -> 3-day: Flynax subtract your active day rather than adding them. See step 6 and 9.

Suggest solution:
I'm not sure how Flynax implement their algorithm in the script, but for such issue. All I can think is the simplest way. When a user renew a plan, just plainly add extra day from what ever that plan duration have. If you currently have 5 days left for listing active time, and you renew with a 10 days, 30 days, 60 days, whatever days, just add those day on top of the current 5 days.

B. BREAK DOWN PROBLEM 2: FEATURED PLAN
Continue in the Video

Quote:

---

Step 10: Upgrade to Featured
Works OK

Step 11: Apply plan: 3-day
Paid featured status is removed. NOT OK.

---

Here we have 2 problems.
1. Upgrade to featured do not add days to active day. If your listing expired tomorrow, and you upgraded your listing to a 5 days featured today. Your listing still expired tomorrow.
2. So what will you do? You renew the listing with the regular plan, right? Guess what, after renew, your featured status is removed. :)

Suggest solution:
1. Add extra active day when user upgrade to featured. For example, user have 2 days to be expired, he add 5 days featured then his listing will active for the next 7 days ( 5 days featured + 2 days regular)
2. Do not remove feature status when user renew their listing with regular plan. May be add separate counter for featured active time, and separate counter for regular active time?

Remarks:
I reported this very same bug in August 10, 2018. You can view it here:
https://forum.flynax.com/showthread....ging-plan-bugs
This was when we had version 4.6.2
I then came back every time we have new version and tell Flynax the bug still not fixed: 4.7, 4.7.2, 4.8.
This post is for version 4.8.1

It took me a huge amount of time to do all this over and over over the past two years. All I sincerely asked is your serious considerations and thoughts.

For a classified script that the main function is to offer listing plan, you would think this listing plan bug is the top priority. I hope Flynax will take it seriously this time and response to me and every customers promptly.

Lets hope this is sorted this time for you. + they post the fixes here for those who want to update before the next version.

You definately should be getting paid to do Flynax's job.

Quote:

---

Originally Posted by Pete Young

Lets hope this is sorted this time for you. + they post the fixes here for those who want to update before the next version.

---

Quote:

---

Originally Posted by Joe Can

You definately should be getting paid to do Flynax's job.

---

Thank you two very much Pete and Joe. Your words make me feel a lot better. I really appreciate it.
Hopefully this will get fix this time, it benefits not only Flynax but also us as customers for having a good working script.

Any official response?


At least let us know if you plan not to resolve this issue.

Hello guys,

We've discussed the issues with plans logic in a meeting

and postponed it for some time

as there are some uncertainties of its implementation

We'll get back to it later when we have more time

but we can't tell you the exact time frames

Thanks

At the very least state the critical error and your intension to fix the issue sometime in the future in your advertising materials so not to mislead consumers.

Quote:

---

Originally Posted by Rudi

Hello guys,

We've discussed the issues with plans logic in a meeting

and postponed it for some time

as there are some uncertainties of its implementation

We'll get back to it later when we have more time

but we can't tell you the exact time frames

Thanks

---

I was about to bump this thread.
Others might think differently. But I think for a classified ads scripts, listing plan bug is extremely crucial and should be the top priority.
When I first raised the issue in 2018, Flynax said it will be fixed in support ticket.
At this point, I don't know what to say. I hope it would not take another 2 years to fix it.
Please lets us know the uncertainties, we might be able to help. Is there any problem with my suggest solutions?

Quote:

---

Originally Posted by Joe Can

Any official response?


At least let us know if you plan not to resolve this issue.

---

Quote:

---

Originally Posted by Joe Can

At the very least state the critical error and your intension to fix the issue sometime in the future in your advertising materials so not to mislead consumers.

---

Thank you for following up with me.

Quote:

---

Originally Posted by Wei Hong

I was about to bump this thread.
Others might think differently. But I think for a classified ads scripts, listing plan bug is extremely crucial and should be the top priority.
When I first raised the issue in 2018, Flynax said it will be fixed in support ticket.
At this point, I don't know what to say. I hope it would not take another 2 years to fix it.
Please lets us know the uncertainties, we might be able to help. Is there any problem with my suggest solutions?

---

It is a critical fix that needs looking into, I am not sure what more logic is required other than what you have pointed out, if flynax went to the shop to buy a loaf of bread and after purchase only found 3/4 of a loaf ? there would be questions asked.

It simply is the maths is not adding up, and you have explained what, when where and why.

I do not think there can be many people who really push flynax out to getting a site up and running and wanting to charge customers so it then does not become a priority ? I might be wrong.

I was and still happy to look at the maths but still do not know what part calculates the sums / does the maths on this, otherwise I would probably be able to see and fix it for you. I have asked but no response on it.

So yes it needs to be fixed as a priority. (Just my view) but I am 100% sure flynax will fix it as thier support is / has been top level in all areas.

The last time I experienced this issue was with GeoCore Classifieds.

Shortly thereafter they went out of business.

Their problem, and likey with Flynax, was their code was significantly outdated and required significant work to fix small issues.

The failure to fix these bugs caused users to start posting many negative online reviews causing them to lose significant sales.

I knew the writing was on the wall after encountering an issue such as this.

I imagine that Flynax is allowing for refunds given this critical error that cannot be fixed?

Joe I would not place GeoCore in the same basket as Flynax. At the start I was also confused with flynax and the team so I understand that. But I will say the team here are great, they are committed to building the best and like any business it takes time, years and still even then there is work to do.

I have no issues with the team here with trust and or future direction, for new people grab the latest version and if any problems have it fixed then move on. I do not think there is one problem in flynax that can not be fixed or worked around for now that I am aware of? so they should then focus on building out their business and fixing a a few issues is part of anywebsite.

I can say with honesty that the flynax team have 100% fixed any issue I have had on my site in a prompt and business like way and that thier service has been without any question.

Joe is new here but very engaging. His registration date is just a couple months ago so it's very normal for him to judge Flynax based on the latest issues and how Flynax responsed to it.
I'm sure other new users will see the same thing. Including me, if I was new.

But I also agree with Pete since I was here for years and years. We helped tested, reported bugs and helping new users on forum here and there.
I have worked with almost every Flynax staffs. Most likely Viktor, Curtis, John, Rudi, Valery, Dmitry, Vladimir, Alan. And have been having good services. I have paid a lot extra for support and customizes too. Flynax is by far the best, I can tell you that Joe in my experiences.

I just for this time don't understand why they did not fix the issue. This is the only time.
Although I recall the other time when I raised the issue of listing not bumping to top after user renewed it. The staff disagreed with me and I had a tough time explaining, at the end they agreed and implemented it as Flynax default. Like: who would want to renew a listing if it is still burried in old pages 30, 40 something right. Anyway it's another topic.

I just want to share with you my 2 most difficult issues with Flynax. Most of the others were OK.

I agree with you two. I also have no issues with the team. So far they are great.

My issues are the documentation and various bugs being encountered.

I await improvement.

Quote:

---

Originally Posted by Joe Can

I agree with you two. I also have no issues with the team. So far they are great.

My issues are the documentation and various bugs being encountered.

I await improvement.

---

Joe, I am also not a fan of the documentation, I am installing a new plugin now with no instructions and am 100% frustrated that flynax do not put a guide with it, it seems they think everybody knows everything as they do. it's like IKEA putting out flat packs with no instructions.

This is something that everybody has been asking for for years, also most if not all have been saying slow down and get what you have working properly in a stable platform for years as well.

Both of these things still need focus from flynax but I suppose I have learnt to try and focus on what is in my control and let flynax focus on what they can control.

Here is a temporary and simple solution regarding the problem with RENEWING LISTING WITH DIFFERENT DURATION PLAN:

go to templates > tpl > blocks > my_listing.tpl:

find:

Code:

---

Only registered members can view the code.

---

and replace with:

Code:

---

Only registered members can view the code.

---

Hi Rudi, thanks for working on this one. Can you describe the outcome of your temp solution and why is would only be considered as such?

As I understand, this is but one of several issues.

Also, users have decided not to test with other plugins until this issue is resolved.

Quote:

---

Originally Posted by Rudi

Here is a temporary and simple solution regarding the problem with RENEWING LISTING WITH DIFFERENT DURATION PLAN:

go to templates > tpl > blocks > my_listing.tpl:

find:

Code:

---

Only registered members can view the code.

---

and replace with:

Code:

---

Only registered members can view the code.

---

---

Thanks Rudi, I will try this out when I have time during weekend.

Quote:

---

Originally Posted by Graham Jupp

Hi Rudi, thanks for working on this one. Can you describe the outcome of your temp solution and why is would only be considered as such?

---

Also interested in the outcome as Graham asked, but I assume it will add the duration correctly instead of subtracting in 1 case or adding both of the plan duration in another case.

Quote:

---

Originally Posted by Joe Can

As I understand, this is but one of several issues.

Also, users have decided not to test with other plugins until this issue is resolved.

---

Yea Joe, although this is by far the most important issue since it effects almost every user. As normally, user would offer more than 1 plan and mostly have different duration in each plan. Once these are fixed we can confidently help Flynax test on new developing plugins

Quote:

---

Originally Posted by Graham Jupp

Hi Rudi, thanks for working on this one. Can you describe the outcome of your temp solution and why is would only be considered as such?

---

Hello,

The simplicity of this solution is that the script calculates and saves duration of different packages correctly, see screenshot Attachment 3908

but displays it incorrectly due to the additional calculation in rlListings.class.php > getMyListings()

this code should be improved in the next update so that it wouldn't affect the "Active Till" date

for now, it's enough to change a piece of code in the .tpl file

Quote:

---

Originally Posted by Rudi

Hello,

The simplicity of this solution is that the script calculates and saves duration of different packages correctly, see screenshot Attachment 3908

but displays it incorrectly due to the additional calculation in rlListings.class.php > getMyListings()

this code should be improved in the next update so that it wouldn't affect the "Active Till" date

for now, it's enough to change a piece of code in the .tpl file

---

So Rudi,

Please correct me if I was wrong. You're saying that all the calculation is correct, only the display is not?
So let go back to my test for example:

Quote:

---

Step 6. Apply plan: 3-day
7 Feb - Incorrect. Should be 9 Feb. ( 6 + 3 = 9 )

---

Meaning that after 7 Feb, the listing is still active until 9 Feb?

Yes, the problem is in using incorrect output (refer to my last post)

Apply my solution and you'll see it

I tried this fix and so something is not good because now it shows that the post date: 20/10/2020 Ad is active: 20/10/2020
So I think it shows a bad date that way.

Sorry,

I've corrected my post with the solution

That's good. Thanks

Quote:

---

Originally Posted by Rudi

Here is a temporary and simple solution regarding the problem with RENEWING LISTING WITH DIFFERENT DURATION PLAN:

go to templates > tpl > blocks > my_listing.tpl:

find:

Code:

---

Only registered members can view the code.

---

and replace with:

Code:

---

Only registered members can view the code.

---

---

I think, the problem is not here.

Quote:

---

Originally Posted by Rudi

Hello,

The simplicity of this solution is that the script calculates and saves duration of different packages correctly, see screenshot https://forum.flynax.com/attachment....tid=3908&stc=1

but displays it incorrectly due to the additional calculation in rlListings.class.php > getMyListings()

this code should be improved in the next update so that it wouldn't affect the "Active Till" date

for now, it's enough to change a piece of code in the .tpl file

---

The point is: When you upgrade/update a listing, it adds NEW listing period to pay date, while it should add OLD listing period to it.

Glad to see more users are engaging in fixing this issue. :)