hello flynax,
If i had a customization done how do i know where and what files have been modified and added to?
thanx
Printable View
hello flynax,
If i had a customization done how do i know where and what files have been modified and added to?
thanx
Hello,
You'd better ask the one who did this customization
and then merge these files with your new script
Hello Rudi,
i just applied the new Patch 4.8.1 and i have only one issue, on listing detail page, cars marque and model in the title are not displayed anymore, i can display all others fields names in title except the car make and model.
the default category listing title form is already built, and it's correctly displayed everywhere except on the listing details page title.
Can you check please what is going wrong ?
thanks in advance,
Mind if I have a look?
Hi Wei,
Sure, i sent you my website in PM
My properties page has the same problem, the category name does not appear in the title of the ad details page.
Someone help me with what’s wrong because it breaks up the nerve slowly. Currently, my ads have totally lame names without the category name, and have been mentioned by my visitors.
Hello guys,
Something went wrong with new groups of phrases after applying the patch,
You need to submit a ticket of this problem and we'll check it and fix it
Sorry for the inconveniences
I know this might be a bit late. But I suggest never apply new patch to a live working site. Test it on local first to make sure everything is OK.
There are also errors in the email template. The ad cannot be updated, it constantly asks for a login, and the link does not appear properly in the email sent.
I preferred to put 4.8.0 back on, unfortunately this update was full of bugs and so useless. I look forward to seeing a new and good update. Until then, however, the 4.8.0 software remains
You have another bug?
I experienced the following bugs in 4.8.1:
- Category does not appear in ad title
- The name of the website does not appear in the email sent about an expired ad, the name of the renewal link is also incorrect
- If I click on the renewal link it is not possible to renew the ad, it always asks for a login after each click
So far I have found so many bugs, I didn't try again as the website was so unusable, so I reverted to the previous 4.8.0 until there was a normal update.
Oops, and I thought they fixed it. I'm so sorry to hear that. I was about to update to 4.8.1 then I saw your comment. May be I will wait. Thank you for reporting these bugs.
Hello guys,
How to reproduce the problem?
or
can someone, who has a live site, create a ticket to investigate the issue?
Thanks
Attachment 3828 Attachment 3829 Attachment 3830
At 4.8.0 everything works fine, but at 4.8.1 there are these bugs.
Now I only have the update on my own machine so I can't show it live.
I test on my local site and I confirm that the category name does not show on listing title on the following locations:
- Listing detail page
- All of my listing page
The email problem I can't reproduce on my local machine so I'm not sure. I've been checking flynax demo site and it's still not update to 4.8.1 yet.
Hi there,
I've found and fixed one similar problem with missing category titles in listings and it doesn't related with patch to 4.8.1 version, it's a bug in 4.8.1 and related with updated and optimized new scopes of phrases in core (unnecessary phrases wouldn't getting from DB anymore and it will help to increase the speed of page loading).
Please open file includes/classes/rlCommon.class.php and found function adaptValue().
1. Find code in top of this function adaptValue()
Replace it to following:Code:Only registered members can view the code.
Code:Only registered members can view the code.
2. Find following code:
and replace it to follow:Code:Only registered members can view the code.
P.S. Please let me know about result.Code:Only registered members can view the code.
Hi Curtis,
I made the change on my local machine and got this error when trying to view a listing page
I tried to paste parts by parts of your code and confirm this part caused the problem, something is wrong with itCode:Only registered members can view the code.
Code:Only registered members can view the code.
Hello Wei Hong,
Yes sorry, please make the following:
Find code in top of this function adaptValue()
Code:Only registered members can view the code.
And replace to following (we need add new class in list):
Code:Only registered members can view the code.
I posted the update, this patch is good so far. At midnight, Cron runs and then I can tell if the mail sent by cron is good or not.
So you reinstalled the patch?Quote:
Originally Posted by Jen4
Unfortunately, there is still a bug. Cron runs down, sends the mail, but not good. I attach the picture from the mail.
Your ad cannot be updated either because it requires a login. If I log in and click on the link again, it will ask me to log in again and will not allow me to update.
Attachment 3831
Hello,
I think it's because you use previous language phrases with the old structure
but should download languages for 4.8.1 from your Customer Area
Can someone help me put up new language terms instead of the old ones? Cutting my nerve apart now, whatever I do is not good. If I completely reload the language, that's not good either, because then a lot of translations are missing.
I don't think there's a problem with language terms. Everything shows up well when I post an ad and come about it in mail with good links and title as well. However, in the email you received about the expired ads, the address is no longer good and clicking on the link will not allow you to update the ad, because it says that you need to have an account, but even if I log in, write the same thing again.
control.inc.php file error. will not allow you to update your ad via the link provided in the email.
I found the error.
reefless.class.php
find it:
replace it with this:Quote:
if (!filter_var(RL_URL_HOME, FILTER_VALIDATE_IP)) {
$domain_info = parse_url(RL_URL_HOME);
$domain_info['domain'] = '.' . preg_replace("/^(www.)?/", "", $domain_info['host']);
// localhost cookies problem workaround
if (!strpos($domain_info['host'], '.')) {
$domain_info['domain'] = null;
}
You can now update your ad via the link provided in the email.Quote:
if (!filter_var(RL_URL_HOME, FILTER_VALIDATE_IP)) {
$domain_info = parse_url(RL_URL_HOME);
$domain_info['domain'] = "." . preg_replace("/^(www.)?/", "", $domain_info['host']);
// localhost cookies problem workaround
if (!strpos($domain_info['host'], ".")) {
$domain_info['domain'] = null;
}
Nice, you managed to pinpoint the problem. Flynax please investigate this issue. I can't test this offline.Quote:
Originally Posted by Jen
Good work Jen... if anyone else is having problems spotting the difference in code, it's the use of single quotes vs double quotes on 2 of the lines. I had to put it into a compare text tool to spot the difference :)
In the email sent by Cron, I couldn’t even test the appearance of the address, but as Rudi wrote that language is a structural flaw, I don’t think so because I looked and the structure exists in the language.
Interestingly, this error only occurs in emails sent about expired ads.Quote:
No phrase found by "categories+name+house" key Pilismarot
Hello,
i confirm having this issue too, it happens also when using the autoposter plugin but only when the ad is posted on facebook, on twitter category ID is dispayed correctly.
This is the listing title published on my business facebook page :
No phrase found by "categories+name+alfa_romeo" key No phrase found by "categories+name+alfa_romeo_159" key Occasion Diesel 90.000 dhs 2015 Marrakech
i let you check this issue too.
Something just isn't good. Today I tried to update the ad on the link in the email sent by cron and again did not allow it to be updated. I just turned off the cookie plugin and allowed the ad to update. I no longer understand these many mistakes. Is it possible that the cookie plugin can also cause an error?
I'm glad that you were able to find so much information regarding this email issues. I'm sure it would be a huge help for Flynax Development to pinpoint and fix the problem.Quote:
Originally Posted by J
The trouble is that the Flynax team should see what the flaws are. On the demo page, the same bugs exist the same way I think. Unfortunately, even though I sent them a bunch of bugs, nothing happens.
I made a video where to see that the ad cannot be updated for some reason.
https://youtu.be/WjVd8m30DmA
I see. So the link in the email does not work. But trying to update ads directly on the website is working right?
That's right, if I want to update the link I received in the mail, it's not good. If I open the same link on the website then it is good.
Yet the two links are the same.
The link structures are not good either in the mail it does not show the title of the ad, in the database I checked everything is good there. I think some of the code is misspelled. I think we should look for the fault around Cron, but that's not certain.
Are you saying the link URL is exactly the same from both the email and directly from within the site itself but only one is working? If so, try the link in the email once again but this time once it attempts to open the URL in the browser, cut and paste that link from the browser window into a new browser, does it then load correctly? It may be that this is a referrer issue in that the website is expecting the link to be referred from within the site itself and is denying external links from within emails?
I recently had a problem with one of my websites (not a flynax driven site) that had been hacked where the hacker edited my .htaccess file so that any referrals coming from my links in google and other search engines were met with a 500 server error, whereas if the URL were typed into the browser manually then it would load the site fine. It took me a while to notice that my search engine visits had dropped hugely as the site appeared to be working fine from my perspective.
I'm thinking of a sessionstart problem. If e.g. in the control.inc.php file, modifiers of something can then be opened from the mail and the ad can also be updated. But if I close the browser and reopen it, if I click on the link I received in the email, it can no longer be updated. I think it could be a sessionstart or a cookie problem.
Guys, it looks like there's a bug in why you can't update your ad via the link you received in the mail.
I replaced the following lines of code with the one in version 4.8.0.
An expert will tell you if this is so good or not.
includes/classes/reefless.class.php
4.8.1 bad.
4.8.0 goodQuote:
*/
public function createCookie(
$cookieName,
$value,
$expireTime = 0,
$path = '',
$domain = '',
$secure = false,
$httponly = false,
$samesite = 'Strict'
) {
global $domain_info;
if (!$cookieName || !$value) {
return false;
}
$options = [
'expires' => $expireTime,
'path' => $path ?: $domain_info['path'],
'domain' => $domain ?: $domain_info['domain'],
'secure' => $secure ?: $this->isHttps(),
'httponly' => $httponly,
'samesite' => $samesite,
];
/**
* @since 4.8.1 - 3rd parameter replaced to $options
* @since 4.7.0
*/
$GLOBALS['rlHook']->load('phpPreCreateCookie', $cookieName, $value, $options);
/*
* @todo - Remove when minimum PHP version will be 7.3
*/
if (PHP_VERSION_ID >= 70300) {
setcookie($cookieName, $value, $options);
} else {
$options['path'] = $options['path'] . "; samesite={$options['samesite']}";
setcookie(
$cookieName,
$value,
$options['expires'],
$options['path'],
$options['domain'],
$options['secure'],
$options['httponly']
);
}
return true;
}
/**
Quote:
**/
public function createCookie($cookie_name = false, $value = false, $expire_time = 0, $cookie_path = false, $cookie_domain = false, $raw_method = false)
{
/**
* @since 4.7.0
*/
$GLOBALS['rlHook']->load(
'phpPreCreateCookie',
$cookie_name,
$value,
$expire_time,
$cookie_path,
$cookie_domain,
$raw_method
);
if (!$cookie_name || !$value) {
return false;
}
$cookie_path = $cookie_path ? $cookie_path : $GLOBALS['domain_info']['path'];
$cookie_domain = $cookie_domain ? $cookie_domain : $GLOBALS['domain_info']['domain'];
if ($raw_method) {
return setrawcookie($cookie_name, $value, $expire_time, $cookie_path, $cookie_domain);
} else {
return setcookie($cookie_name, $value, $expire_time, $cookie_path, $cookie_domain);
}
}
/**
Jen, I wonder if the following code in your snippet relates to a possible referrer issue that I mentioned in my earlier post:
Code:Only registered members can view the code.